Merged
Conversation
PierreQuinton
added
package: autojac
cc: refactor
ValerianRey
changed the title
ValerianRey
reviewed
Mar 28, 2025
ValerianRey
reviewed
Mar 28, 2025
ValerianRey
reviewed
Mar 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
ValerianRey
reviewed
Mar 28, 2025
ValerianRey
reviewed
Mar 28, 2025
ValerianRey
reviewed
Mar 28, 2025
…and make them assert the required and output keys are correct
ValerianRey
approved these changes
Mar 28, 2025
Contributor
ValerianRey
left a comment
ValerianRey
left a comment
There was a problem hiding this comment.
LGTM.
In future PRs, we should:
- Do the same thing for runtime checks of TensorDict: move them from the init to a check method to make them optional.
- Make typing more strict in Transforms. If instead of having Iterable[Tensor] arguments we have for instance list[Tensor], we can safely defer the call to set(...) in check_and_get_keys, which will save some computations.
Note that the check that we removed from TensorDict (test_keys_are) is actually not necessary to replace by extra unit tests: we test all transforms well enough to ensure that their output keys are what we expect. No need for another PR for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.